Enable xml type support for oracle for dts-connectors only#657
Open
vanshikaagupta22 wants to merge 1 commit intodata-integrations:developfrom
Open
Enable xml type support for oracle for dts-connectors only#657vanshikaagupta22 wants to merge 1 commit intodata-integrations:developfrom
vanshikaagupta22 wants to merge 1 commit intodata-integrations:developfrom
Conversation
vanshikaagupta22
force-pushed
the
oracle-supportforxml
branch
from
068942e to
3c5ce2c
Compare
| case INTERVAL_YM: | ||
| case LONG: | ||
| return Schema.of(Schema.Type.STRING); | ||
| case Types.SQLXML: |
Contributor
There was a problem hiding this comment.
we should add a comment explaining for future context that it is only added to support DTS connector and currently not in a working state in CDAP plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables support for the Oracle XMLType by mapping it to the STRING data type in BigQuery. Due to dependency conflicts in the pom.xml affecting CDF class loading, this feature is currently enabled exclusively for the DTS side via a new boolean flag (isXmlTypeEnabled).